Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JEP] subdomain and repository for publishing schemas under jupyter.org #108

Merged
merged 3 commits into from
Jun 5, 2023

Conversation

Zsailer
Copy link
Member

@Zsailer Zsailer commented Apr 26, 2023

Follow up to #107

Adds a JEP proposing to create a subdomain under jupyter.org and a repository for publishing machine- and human-readable JSON Schemas provided by the core Jupyter ecosystem.

cc @bollwyvl @tonyfast

Voting from @jupyter/software-steering-council

@Zsailer Zsailer changed the title Add JEP: 'jupyter.org subdomain for schemas' subdomain and repository for publishing schemas under jupyter.org Apr 26, 2023
@Zsailer Zsailer changed the title subdomain and repository for publishing schemas under jupyter.org [JEP] subdomain and repository for publishing schemas under jupyter.org Apr 26, 2023
@willingc
Copy link
Member

Thanks @Zsailer. This looks great.

Co-authored-by: Afshin Taylor Darian <git@darian.email>
@Zsailer
Copy link
Member Author

Zsailer commented May 2, 2023

cc @jupyter/software-steering-council

@rpwagner
Copy link

rpwagner commented May 2, 2023

+1

My vote

Copy link
Contributor

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @Zsailer

jupyter-subdomain-for-schemas/proposal.md Outdated Show resolved Hide resolved

## Packaging

As a widely-implemented standard, JSON Schema can be used to build packages, at various levels of specificity, that could be consumed by both Jupyter downstreams.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another way to distribute and ensure single source of truth is the use of git submodules. But I guess that as it is not a common pattern in Jupyter ecosystem, we should focus on distributing packages.

Co-authored-by: Frédéric Collonval <fcollonval@users.noreply.github.com>
@Zsailer
Copy link
Member Author

Zsailer commented May 23, 2023

Pinging @jupyter/software-steering-council again for any last minute comments / votes. 😃

@ibdafna
Copy link
Contributor

ibdafna commented May 23, 2023

+1
Thank you!

@SylvainCorlay
Copy link
Member

This JEP has been in voting phase for over one month. We have 10 in favor and 1 person who did not vote.

This JEP is approved! 🎉

@SylvainCorlay SylvainCorlay merged commit cc55334 into jupyter:master Jun 5, 2023
@SylvainCorlay
Copy link
Member

Congrats to @Zsailer for getting this through.

@ivanov
Copy link
Member

ivanov commented Jun 10, 2023

I've also belatedly approved this, thanks everyone!

fcollonval added a commit to filipsch/enhancement-proposals that referenced this pull request Jun 13, 2023
fcollonval added a commit that referenced this pull request Jul 11, 2023
* Add JEP for adding $schema to notebook format

* wip: update from meeting

* Update add-schema-to-notebook-format.md

change the schema to draft2020-12

* Update URI to align with JEP #108

---------

Co-authored-by: Filip Schouwenaars <filipsch@users.noreply.github.com>
Co-authored-by: Angus Hollands <goosey15@gmail.com>
Co-authored-by: Tony Fast <tony.fast@gmail.com>
Co-authored-by: Frédéric Collonval <fcollonval@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.